tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Ludvig #646

Closed Luxwor closed 1 year ago

Luxwor commented 1 year ago

Some shit

codecov-commenter commented 1 year ago

Codecov Report

Merging #646 (4bf840d) into develop (0f830bd) will decrease coverage by 0.17%. The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop     #646      +/-   ##
===========================================
- Coverage    88.10%   87.92%   -0.18%     
===========================================
  Files           49       49              
  Lines         2270     2278       +8     
  Branches       172      172              
===========================================
+ Hits          2000     2003       +3     
- Misses         270      275       +5     
Impacted Files Coverage Δ
about.cpp 0.00% <0.00%> (ø)
game.cpp 97.96% <ø> (ø)
color.cpp 97.36% <100.00%> (+0.22%) :arrow_up:
read_only.h 33.33% <0.00%> (-50.01%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

richelbilderbeek commented 1 year ago

Hi @Luxwor, could you please (1) describe what you did better (as now there is no time pressure :-) ), (2) find a reviewer? If yes and yes, we'll happily review and merge :+1:!

Luxwor commented 1 year ago

I should really not have pushed

Luxwor commented 1 year ago

Mabel I should have. Just pushing with an untested discord link that still runs.

Luxwor commented 1 year ago

issue #598 is not finished but everything else is good according to me