tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Action type none should be idle #656

Closed EvoLandEco closed 1 year ago

EvoLandEco commented 1 year ago

none could be misleading and less informative than idle, see the class action_type:

enum class action_type
{
  turn_left,
  turn_right,
  accelerate_forward,
  accelerate_backward,
  shoot,
  none,
  shoot_stun_rocket
};

suggested change:

enum class action_type
{
  turn_left,
  turn_right,
  accelerate_forward,
  accelerate_backward,
  shoot,
  none, >>>> idle,
  shoot_stun_rocket
};
TheoPannetier commented 1 year ago

Good idea! I think an easy way to implement this would be to simply change references to action_type::none in existing tests to action_type::idle, then work from there to make the tests pass :)

EvoLandEco commented 1 year ago

closed by #667