Closed TheoPannetier closed 1 year ago
Merging #730 (ccc3e55) into develop (f58dc20) will increase coverage by
0.22%
. The diff coverage is100.00%
.:exclamation: Current head ccc3e55 differs from pull request most recent head b86cf96. Consider uploading reports for the commit b86cf96 to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## develop #730 +/- ##
===========================================
+ Coverage 87.00% 87.23% +0.22%
===========================================
Files 37 37
Lines 1655 1661 +6
Branches 126 0 -126
===========================================
+ Hits 1440 1449 +9
+ Misses 215 212 -3
Impacted Files | Coverage Δ | |
---|---|---|
src/player.cpp | 98.89% <100.00%> (+0.03%) |
:arrow_up: |
src/player.h | 100.00% <100.00%> (ø) |
|
src/coordinate.h | 100.00% <0.00%> (ø) |
|
src/read_only.h | 66.66% <0.00%> (+33.33%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
It is time to merge this, thanks to the deadline posted on Discord and copy-pasted here:
Dear Game Design Team, among others @Oliver and @Tianjian, please review https://github.com/tresinformal/drakkar/pull/730 which is the Game Design Document before Wednesday March 22nd 17.00. If no one has reviewed it, it is accepted as-is.
Oops, this should have been 2 separate PRs... Oh, well.
Game design document (see #728 and chat in the big table)
I made a first version for a design document, detailing everything that the game should do and contain for the minimum viable game (it's not that much!). Please review and feel free to object, I may have missed something.
@EvoLandEco and @ollyturner, please pay especially close attention to the rules I detailed for player size and invulnerability. Let me know if you spot that this would not work in practice, or if you have a better system in mind, or if I have left something important aside.
Once we reach a consensus on the rules, I'll make some housekeeping in the issues to make them consistent with the proposed plan.
Also, we should have a defined policy for how to add or changes features from the design doc, when we want to take the game in a new direction. I think that any new feature or idea should be discussed first, then added to the design doc if well received, and then only we should be able to start working on it (by making issues and tests, and solving them). Any idea on how to implement this?
Test and solution for:
726