Closed janclod closed 1 year ago
Merging #731 (c23e35c) into develop (b1b6da6) will increase coverage by
0.28%
. The diff coverage is100.00%
.:exclamation: Current head c23e35c differs from pull request most recent head 6050eec. Consider uploading reports for the commit 6050eec to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## develop #731 +/- ##
===========================================
+ Coverage 86.91% 87.19% +0.28%
===========================================
Files 37 38 +1
Lines 1643 1656 +13
Branches 126 0 -126
===========================================
+ Hits 1428 1444 +16
+ Misses 215 212 -3
Impacted Files | Coverage Δ | |
---|---|---|
src/game.cpp | 96.79% <ø> (+0.04%) |
:arrow_up: |
src/coordinate.cpp | 100.00% <100.00%> (ø) |
|
src/game.h | 100.00% <100.00%> (ø) |
|
src/menu.cpp | 100.00% <100.00%> (ø) |
|
src/menu.h | 100.00% <100.00%> (ø) |
|
src/coordinate.h | 100.00% <0.00%> (ø) |
|
src/read_only.h | 66.66% <0.00%> (+33.33%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hi @richelbilderbeek
I am creating a PR to ask this question because it seemed the easiest way for me.
I am trying to fix the following error:
Do you think that it is fine to push this into
develop
? Or will your and others build break? GitHub actions seems fine... see hereCould you build my branch on your machine? This should already give me an indication...