search

tresinformal / drakkar

The tresinformal video game called 'Drakkar'
GNU General Public License v3.0
11 stars 4 forks source link

Fix bug in collision detection #732

Open richelbilderbeek opened 1 year ago

richelbilderbeek commented 1 year ago

Currently, health and diameter are the same thing, just on different scales (to be precise: diameter == 100.0 * health).

However, when this was implemented, some collision tests failed. These were commented out by FIX_ISSUE_732.

Make those tests work again :-)

OggyOggelito commented 1 year ago

732 has nothing to do with get_diameter or health?

janclod commented 1 year ago

This issue is indirectly related to changes in get_diameter (<- which return m_health multiplied by a constant factor). Should we change the way game object is constructed? Should be players be spaced correctly inside game constructor?

Luxwor commented 1 year ago

there seams to be an issue but the test doesn't fail when I run it