codecov-commenter
commented
1 year ago Codecov Report
Merging #733 (6fb0e28) into develop (f58dc20) will decrease coverage by
0.20%. The diff coverage is100.00%.:exclamation: Current head 6fb0e28 differs from pull request most recent head ef85151. Consider uploading reports for the commit ef85151 to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## develop #733 +/- ##
===========================================
- Coverage 87.00% 86.81% -0.20%
===========================================
Files 37 37
Lines 1655 1615 -40
Branches 126 0 -126
===========================================
- Hits 1440 1402 -38
+ Misses 215 213 -2 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/game.cpp | 95.53% <ø> (-1.27%) |
:arrow_down: |
| src/game.h | 100.00% <ø> (ø) |
|
| src/player.cpp | 98.90% <100.00%> (+0.04%) |
:arrow_up: |
| src/player.h | 100.00% <100.00%> (ø) |
|
| src/coordinate.h | 100.00% <0.00%> (ø) |
|
| src/game_functions.cpp | 81.66% <0.00%> (+3.33%) |
:arrow_up: |
| src/read_only.h | 66.66% <0.00%> (+33.33%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
TheoPannetier
Me and @OggyOggelito worked on #708 and now the health is the diameter; to be precise, the health is the diameter divided by a 100.0.
This fix, however, exposes problems in the collision detection. Fixing that is beyond the fixed Issue, hence we opened a new issue #732, to revise the collision detection and we
IFDEF-ed away the failing tests.Good luck reviewing :+1: