PHP 5.4 incompatabilities

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Upgrade to Nas4Free 141 and PHP 5,4 breaks RSS extension
2.
3.

What is the expected output? What do you see instead?
Mainly issues with "&" in some files but also syntax error:
Fatal error: 'continue' operator with non-constant operand is no longer 
supported in /mnt/zfsroot/active/apps/RSS/www/ext/RSS/Torrent.php on line 323 

What version of the product are you using? On what operating system?
RSS-FreeNAS70-19122010

Please provide any additional information below.
I've fixed most but last file is beyond my skills.  Would you consider an 
update?

Original issue reported on code.google.com by badi...@gmail.com on 6 Jul 2012 at 7:57

[GoogleCodeExporter]

Hi i have the same problem if i upgrade to Nas4Free, Tresni are you still 
offering support?

Original comment by sa...@tyrezone.net.au on 7 Aug 2012 at 12:13

[GoogleCodeExporter]

I have since fixed this issue. I have attached the updated files.
All seems to be working as far as I can tell.

Original comment by badi...@gmail.com on 8 Aug 2012 at 3:36

Attachments:

• RSS.tgz

[GoogleCodeExporter]

Thanks for your efforts in fixing this!
I spent some time already today installing it manually as it seems the php 
install script was throwing me some errors on the latest release of NAS4FREE.

Anyways... Used your files, now the PHP errors in the web console are fixed.

Original comment by FuzzBal...@gmail.com on 17 Nov 2012 at 6:30

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I had some more problems when upgrading Nas4Free to 431.
Something to do with the location of php.

Here is my fix for the install.php and the cron.sh

Original comment by badi...@gmail.com on 18 Nov 2012 at 2:19

Attachments:

• RSS.tar

[GoogleCodeExporter]

Badi,
I used your latest archive from an "update" and "clean" instal - worked 
perfectly.
Your efforts are much appreciated.

At some point, I'll post this over at the NAS4FREE forums in hopes that it will 
get more attention.

Thanks again

Original comment by FuzzBal...@gmail.com on 1 Dec 2012 at 5:16

[GoogleCodeExporter]

Used the fix in comment 5 and got an error:

X-Powered-By: PHP/5.4.9
Content-type: text/html

Linking www/rss_about.php as /usr/local/www/extension_rss_about.php
Linking www/rss_feed_edit.php as /usr/local/www/extension_rss_feed_edit.php
Linking www/rss_feed_manage.php as /usr/local/www/extension_rss_feed_manage.php
Linking www/rss_filter_edit.php as /usr/local/www/extension_rss_filter_edit.php
Linking www/rss_filter_manage.php as 
/usr/local/www/extension_rss_filter_manage.php
Linking www/rss_history.php as /usr/local/www/extension_rss_history.php
Linking ext directory
Looking for cron job...found

Warning: Illegal string offset 'rule' in /mnt/usbdata/archive/RSS/install.php 
on line 79

Warning: Invalid argument supplied for foreach() in 
/mnt/usbdata/archive/RSS/install.php on line 79
Saving configuration changes

Finished installing the RSS extension for transmission.  Please bear
in mind that this extension pulls most of transmission's settings
from FreeNAS' XML configuration file.  If you have modified the
transmission installation, you may need to modify
/mnt/usbdata/archive/RSS/www/ext/rss_functions.inc
to reflect your changes.  Look at the $TRANSMISSION variable at the
top of the file.

--------------------------------------
I am using NAS4Free 9.1.0.1 - Sandstorm (revision 573)

Original comment by shadwm...@gmail.com on 4 Jan 2013 at 10:33

[GoogleCodeExporter]

Hi
I have installed this as per the instructions, everything seems to work except 
one thing.
runnung PHP Version 5.4.16
the cron job will not run, if I run the function manually the following error 
is produced.
Fatal error: Call-time pass-by-reference has been removed; If you would like to 
pass argument by reference, modify the declaration of add_item(). in 
/usr/local/www/sys/rss_cron.php on line 124
I have tried debugging, but I am not that good at php coding.
Hoping one of you realy smart php coders can fix it.
I am running latest nas4free version 9.1.0.1 - Sandstorm (revision 775), when 
getting php info
PHP Version 5.4.16 (Seems was upgraded with NAS4FREE revision 752)
FreeBSD xxxxxx.local 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0 r251670M: Thu Jun 
13 01:59:24 CEST 2013 
root@dev.nas4free.org:/usr/obj/nas4free/usr/src/sys/NAS4FREE-amd64 amd64 

Original comment by ian.p.ha...@gmail.com on 27 Jul 2013 at 12:45