search

trevanhetzel / barekit

A bare minimum responsive framework
http://trevanhetzel.github.io/barekit
MIT License
203 stars 16 forks source link

Conflict with Modernizr (SMIL) #24

Closed scottzirkel closed 10 years ago

scottzirkel commented 10 years ago

I was using a Modernizr CDN that has SMIL enabled and noticed padding on the body. Seems to be from the class*=sm selector picking up the smil class name on the html element.

Not a big issue with Modernizr, but this does mean that any class beginning with sm (or any of the other size prefixes) would inherit undesired styles. Perhaps a scoped prefix (ie: bk-) would solve this?

trevanhetzel commented 10 years ago

Aha, yes, that dang selector. The scoped prefix is an excellent option. I don't like having to write a longer class (.bk-sm-6), but that's probably the only option to avoid conflicts without scoping it to like a .col class as well (which I dislike).

scottzirkel commented 10 years ago

Yeah, prefixes aren't that great, unless it's something awesome. I recommend .something-awesome-sm-6.

trevanhetzel commented 10 years ago

Fixed with 6b3b0dbafdeea83c5a6707d068273b5a6a799184

See https://github.com/a2labs/barekit/blob/master/CHANGELOG.md for more info.