search

trevanhetzel / barekit

A bare minimum responsive framework
http://trevanhetzel.github.io/barekit
MIT License
203 stars 16 forks source link

Allow for more flexible accordion description terms #49

Closed dkjellerson closed 9 years ago

dkjellerson commented 9 years ago

Working with the accordion we realized it was very strict on using an anchor tag - with no children - as the direct child of the description term. We wanted to created a more complex description term that could handle children with images, titles, other divs, etc.

Hope you approve, thanks!

trevanhetzel commented 9 years ago

Great feedback and solution! I started to type about how I was going to hold off on merging because with this method ANY element inside the dt would trigger the accordion. But the more I look at the structure again and think about my original decision to use a dl, the more it does make sense to make any element inside the dt as the "trigger".

So, thanks!