Closed JasonMendoza2008 closed 1 year ago
Merging #127 (68750e8) into dev (4766703) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## dev #127 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 29 29
Lines 1936 1936
=======================================
Hits 1879 1879
Misses 57 57
Files Changed | Coverage Δ | |
---|---|---|
statannotations/Annotator.py | 91.48% <ø> (ø) |
Hello @JasonMendoza2008 ,
Thank you for the PR!
I'm sorry I didn't check this sooner. In fact, I discovered it when I tried to update the documentation and add an example, and I implemented it independently.
A few more changes were required as it shouldn't be an argument for Annotator's __init__
at all (because configuring once is also persistent if not updated), and there were no tests checking the parameter at all.
I'm finalizing it and shipping it in v0.6.0.
See you for the next one, I hope :)
hide_non_significant
optional kwarg was added toAnnotator
but wasn't made configurable. This PR aims at fixing this bug.This worked:
This did not but should:
Both work after the PR. Tests were passed on
Python 3.11.1
.I squashed everything like suggested last time I made a PR.