search

trevismd / statannotations

add statistical significance annotations on seaborn plots. Further development of statannot, with bugfixes, new features, and a different API.
Other
624 stars 67 forks source link

Chi Squared test between categorical data and asterisk change on the stars when exporting graphs into LaTeX #32

Open CameraEngineer opened 2 years ago

CameraEngineer commented 2 years ago

I posted this question/answer to statannot and have not had a chance to try it with statannotations. I'll see what I can do but below is the issue I had and the way to solve the problem. I wanted to add chi-squared tests. I'm new to trying to do a Pull Request and am assuming that the code would not work if I tried to make one. What would be the best route to go about doing so?

Here is the link to the previous closed issue: https://github.com/webermarcolivier/statannot/issues/65

Thanks!

trevismd commented 2 years ago

Hi, thank you for your message. At the moment, statannotations would work for Nx2 contingency tables. However, support for higher dimensions would be very useful (also for ANOVA, KW, and many others).

Have you used git at the time of writing this ? If so, this repository having the full commit history of statannot, you should be able to make a PR here.

If not, did you work on this based on a specific version of statannot ? In that case (and you can tell which one), we can do a "diff" between it and your code to see your changes. Then it will be easier to go over your suggestions ;)

CameraEngineer commented 2 years ago

Hi Florian,

I use git but from a different perspective. I use GitLab for my engineering work. I'm still learning how to use git and did not at the time when I modified the code to work for my needs.

I installed statannot via pip install and just modified the code. Do you have any recommendations on how I could go about either doing a pull request? I just saw that I was using version 0.2.3. when I checked "print(statannot.version)".

Thanks so much,

Kiffer

On Wed, Sep 29, 2021 at 12:38 PM Florian Charlier @.***> wrote:

Hi, thank you for your message. At the moment, statannotations would work for Nx2 contingency tables. However, support for higher dimensions would be very useful (also for ANOVA, KW, and many others).

Have you used git at the time of writing this ? If so, this repository having the full commit history of statannot, you should be able to make a PR here.

If not, did you work on this based on a specific version of statannot ? In that case (and you can tell which one), we can do a "diff" between it and your code to see your changes. Then it will be easier to go over your suggestions ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trevismd/statannotations/issues/32#issuecomment-930443307, or unsubscribe https://github.com/notifications/unsubscribe-auth/APTIJN4YNNIFYXNLT7INBILUENMKNANCNFSM5E6OXRAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

trevismd commented 2 years ago

Hi Kiffer,

For convenience, I created a branch statannot here. Therefore, you may want to

CameraEngineer commented 2 years ago

Hi Florian,

I was able to push the changes to the statannot branch. That was my first pull request. Hopefully, I did the correct steps.

Let me know if that will work.

On a side note, statannot helped my with my Ph.D.!!! I speak so highly of it :) I'm now trying to see the difference between statannotations and statannot for ease of implementation.

What was the motivation for creating statannotations?

Thanks,

Kiffer

On Thu, Sep 30, 2021 at 12:28 AM Florian Charlier @.***> wrote:

Hi Kiffer,

For convenience, I created a branch statannot here. Therefore, you may want to

  • Fork this repository & clone it locally
  • Create a new branch based on the statannot branch (ex git checkout -b statannot-chisquared statannot)
  • Change the source to your code (replace the file if all was in one)
  • (If your editor allows to see the changes, maybe adapt them to reduce them to the strict minimum for your new features)
  • Commit your changes & push them to your repository
  • Open a PR to merge into the statannot branch of this repository

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trevismd/statannotations/issues/32#issuecomment-930836031, or unsubscribe https://github.com/notifications/unsubscribe-auth/APTIJN7JEHME2L62LI3UAI3UEP7QHANCNFSM5E6OXRAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.