search

trevismd / statannotations

add statistical significance annotations on seaborn plots. Further development of statannot, with bugfixes, new features, and a different API.
Other
655 stars 73 forks source link

added show_non_significant flag to annotator #66

Closed sepro closed 1 year ago

sepro commented 2 years ago

This is a proposed solution to discussion #50 with a single flag to show/hide non-significant issues.

@trevismd: I based this on the master branch only noticed later that PR should be based on the latest dev branch, though as merging is possible I hope this isn't an issue.

codecov[bot] commented 2 years ago

Codecov Report

Merging #66 (fafb0c6) into dev (2a5ebe1) will decrease coverage by 0.24%. The diff coverage is 54.54%.

@@            Coverage Diff             @@
##              dev      #66      +/-   ##
==========================================
- Coverage   97.04%   96.80%   -0.25%     
==========================================
  Files          29       29              
  Lines        1898     1908      +10     
==========================================
+ Hits         1842     1847       +5     
- Misses         56       61       +5
Impacted Files Coverage Δ
statannotations/stats/StatResult.py 86.53% <40.00%> (-4.96%) :arrow_down:
statannotations/Annotator.py 91.29% <66.66%> (-0.38%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sepro commented 1 year ago

https://github.com/trevismd/statannotations/pull/95 is the PR with the improved implementation, based on our discussion here.