Closed JasonMendoza2008 closed 1 year ago
Merging #84 (ace2592) into dev (c123a61) will increase coverage by
0.01%
. The diff coverage is100.00%
.:exclamation: Current head ace2592 differs from pull request most recent head 45cfdc5. Consider uploading reports for the commit 45cfdc5 to get more accurate results
@@ Coverage Diff @@
## dev #84 +/- ##
==========================================
+ Coverage 97.04% 97.06% +0.01%
==========================================
Files 29 29
Lines 1898 1907 +9
==========================================
+ Hits 1842 1851 +9
Misses 56 56
Impacted Files | Coverage Δ | |
---|---|---|
tests/test_annotator.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hello @trevismd I have squashed all commits and restored the blank line. For some reason I had to use the terminal and not PyCharm to squash the commits and to force push because they were greyed out in my IDE. Do you have any idea why that's the case? It's the first time that that's happening to me.
@trevismd anything I should do? Tests failed on Python 3.6
but it seems to be github related.
Thank you for your contribution and patience, @JasonMendoza2008 ! The problem is due to the availability of Python 3.6 in Ubuntu 22.04. I've already pushed a commit for it to the dev branch so this should work fine. (Finally, I'm afraid I can't come up with any idea about your squashing issue)
To enhance tests for float values on the x_axis (they are currently supported). Also added PyCharm IDE files to the .gitignore file to avoid accidental commit of these files. Refers to this issue: https://github.com/trevismd/statannotations/issues/65
Not sure if the test is properly coded (EDIT: second commit should make the whole thing closer to what was already in place). In case the commit is not clear, here is the code (user-oriented) to create the figure and make sure the result is the one expected that I used as inspiration to make the unit test (I checked it did not run and now runs with your latest commits):