trevor-laher / OnDemandMinecraft

An AWS hosted Minecraft server that will only run when players are active. Players can start the server through a simple UI accessed through free Heroku server hosting.
MIT License
516 stars 69 forks source link

autoshutdown.sh no longer works as of the Minecraft 1.16 snapshot releases #23

Open jacoblee5106 opened 4 years ago

jacoblee5106 commented 4 years ago

autoshutdown.sh no longer works with the Minecraft 1.16 snapshots because of a change in wording for the amount of players online. Previously, it was written as " There are X of a max X players online" and now it is written as " There are X of a max of X players online".

The fix is simple enough. You just have to edit line 4 in autoshutdown from: PLAYERSEMPTY=" There are 0 of a max 20 players online" to PLAYERSEMPTY=" There are 0 of a max of 20 players online"

However, not sure how it wants to be handled for backwards compatibility with servers older than 1.16.

trevor-laher commented 4 years ago

Hi, thanks for pointing this out. I believe a solution for both versions will work fine by simply adding an additional condition. Feel free to add this yourself and make a pull request or I can make the changes in a few days!

On Tue, Feb 18, 2020 at 1:42 AM jacoblee5106 notifications@github.com wrote:

autoshutdown.sh no longer works with the Minecraft 1.16 snapshots because of a change in wording for the amount of players online. Previously, it was written as " There are X of a max X players online" and now it is written as " There are X of a max of X players online".

The fix is simple enough. You just have to edit line 4 in autoshutdown from: PLAYERSEMPTY=" There are 0 of a max 20 players online" to PLAYERSEMPTY=" There are 0 of a max of 20 players online"

However, not sure how it wants to be handled for backwards compatibility with servers older than 1.16.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/trevor-laher/OnDemandMinecraft/issues/23?email_source=notifications&email_token=AFNUAIZ7LIHMV3J5YG62KCLRDLK77A5CNFSM4KWWX4X2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IODSG3A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFNUAI5UXTY6K64OBXAFVQDRDLK77ANCNFSM4KWWX4XQ .