Closed macMikey closed 5 years ago
@macMikey Can you try the PR I've submitted and see if it sufficiently addresses this issue?
No, see the notes on the PR.
OK, latest PR fixes it. Suggestion: the yaml parser can be more hepful than "invalid yaml file". There are several types of failures that the parser detects.
That sounds like a great PR for you to submit ;-)
ok, leave the issue open, and i'll work on it this weekend. I was thinking about this last night when I was expletive-deep in the framework chasing this.
I'm going to close this issue as the issue is fixed. Better YAML error reporting should be handled under a different issue.
If a helper has an invalid helper.yml file, loadHelperConfigurationFile returns "Invalid YAML File", but then expandHelperAssetsFileReferenceArray doesn't do anything with that information. It just skips the helper and moves on to the next one. The result is that the helper doesn't load, but no error is thrown.