search

trevordevore / levure

Application development framework for LiveCode
MIT License
32 stars 14 forks source link

Report error loading helper.yml files #108

Closed trevordevore closed 5 years ago

trevordevore commented 5 years ago

Resolves #106

macMikey commented 5 years ago

Does not fix it. A couple of things worth noting: 1) I don't see any code to report the error. You added lines 2364 and 2365, which just cause the inner repeat to exit to the outer repeat, but that isn't any different than not adding the entry. I think you would have to exit both repeats to make it to the point of reporting the error, so at the end of the outer repeat, you could check for tError, or at this point when you are assigning tError, you could just return tError for error. 2) kVersion is still on 0.9.5.0, so verifying that the correct version is pulled involves a bit of sleuthing

trevordevore commented 5 years ago

@macMikey Oops. I've added an exit to the main repeat loop. Please try again. Regarding version - if you check out and use the branch for this PR (tkd-report-helper-config-errors) you are ensured you have the right version. Version number increases for the library as a whole aren't part of bugfix PRs.

macMikey commented 5 years ago

For the version, the only reason I made that comment is that you have 0.9.6 and 0.9.7 in the tags, but this version (and the ones further up) are still 0.9.5. Anyway, yes, that fixes it.

trevordevore commented 5 years ago

Ah, so you are saying the Levure library version is out of sync with the tags. That makes more sense :-)