Fix/clarify file_system helper README file

trevordevore / levure

Application development framework for LiveCode

MIT License

32 stars 14 forks source link

Fix/clarify file_system helper README file #126

Closed macMikey closed 5 years ago

macMikey commented 5 years ago

File makes references to app.yml that should be app.livecodescript
File makes references to processMyFiles that should be processMyURL
Make it clearer that you have to write your own processMyFiles and processMyURL routines
Inspired by https://forums.livecode.com/viewtopic.php?f=4&t=31731&p=173056&hilit=levure+file#p173056

trevordevore commented 5 years ago

Thanks @macMikey. I wonder if the reason the changes disappears is because you are submitting PRs against your macMikey:develop branch. I would recommend creating a branch dedicated to this particular fix that is based off of trevordevore:develop. That way if you happen to change macMikey:develop later on (e.g. before I merge your PR in) then it doesn't mess up this PR.

macMikey commented 5 years ago

I'll keep an eye on it. I think I have a couple other PR's that I have to work on before they can be accepted. It would be uncool to lose the work on them, too...

trevordevore commented 5 years ago

The other two PRs from you that are open have their own branches. You won't have problems with those.

macMikey commented 5 years ago

The original one did, too (that's why it has the /hotfix prefix on it). When I finished the branch it was merged into my develop and then PR'd to you, which why the title of the PR is for the merge, instead of the title from the commit. It's weird, the annotation from the commit was gone, too.