Closed macMikey closed 5 years ago
Thanks @macMikey. I wonder if the reason the changes disappears is because you are submitting PRs against your macMikey:develop
branch. I would recommend creating a branch dedicated to this particular fix that is based off of trevordevore:develop
. That way if you happen to change macMikey:develop
later on (e.g. before I merge your PR in) then it doesn't mess up this PR.
I'll keep an eye on it. I think I have a couple other PR's that I have to work on before they can be accepted. It would be uncool to lose the work on them, too...
The other two PRs from you that are open have their own branches. You won't have problems with those.
The original one did, too (that's why it has the /hotfix
prefix on it). When I finished the branch it was merged into my develop and then PR'd to you, which why the title of the PR is for the merge, instead of the title from the commit. It's weird, the annotation from the commit was gone, too.