Closed trevordevore closed 7 years ago
@spencerlearning This PR changes the syntax for preferences to match the data folder syntax. I think we discussed making this change. Can you review and confirm?
@trevordevore It looks good. The app.yml
preferences section needs to be changed for this to work. Also, preferences filename
instead of just preferences
makes it more clear:
preferences filename:
user:
default:
macos:
windows:
linux:
ios:
android:
shared:
default:
macos:
windows:
linux:
@spencerlearning I've updated the app.yml file. Anything else?
@trevordevore What do you think about making it preferences filename:
instead of just preferences:
. "Preferences" is pretty vague for the new user (is it referring to a folder, a file name, default values?). Adding filename
makes it clear.
Also, a trivial thing, but you might consider moving linux
below windows
so the platform ordering is consistent with the application data folder
section:
preferences filename:
user:
default:
macos:
windows:
linux:
ios:
android:
If you make it preferences filename
you will need to change the line in prefFilenameForPlatform
from
put "preferences" into tA[1]
to
put "preferences filename" into tA[1]
@spencerlearning I agree with the "filename" addition. Done. I also reordered "linux". Any other thoughts before I merge?
Everything looks good.
@macMikey FYI preferences syntax has changed in app.yml
And just like that it goes from "what do you think" to boom. done, before I can even say "yeah, I like 'preferences filename'"
Got to get to a 1.0 release :-)
New syntax:
preferences: user: default: [optional default name] macos: [macos name] ios: [ios name] windows: [windows name] android: [android name] shared: [same as user]