excel Parser hangs if SharedStrings.xml is missing from file being parsed.

trevordixon / excel.js

Native node.js Excel file parser. Only supports xlsx for now.

MIT License

267 stars 85 forks source link

excel Parser hangs if SharedStrings.xml is missing from file being parsed. #50

Open daric81 opened 7 years ago

daric81 commented 7 years ago

Got caught for a while on this issue. If SharedStrings.xml is mandatory then an error should be thrown.

trevordixon commented 7 years ago

You're right! Thanks for the report.

Out of curiosity, do you know about https://github.com/SheetJS/js-xlsx? If so, why use excel.js instead of that? I haven't touched this in a long time, and I wonder if I should just point people to that other option, or if there's something compelling about this that I should make clear or enhance.

Thanks again!

daric81 commented 7 years ago

I didn't actually. Don't know how I didn't come across that project when looking at what was out there. I'll definitely take a look when I'm back working on import/export in our app.

Cheers