trevorhuang1 / cpt_warmup

Apache License 2.0
0 stars 1 forks source link

cpt_warmup/binarycpt/home #9

Open utterances-bot opened 10 months ago

utterances-bot commented 10 months ago

CPT Warmup Fin | Binary Logic

CPT Warmup Tangibles

https://trevorhuang1.github.io/cpt_warmup/binarycpt/home

ak146 commented 10 months ago

Individual Review Andrew K grading Trevor Huang

Individuals Video, Issue(s), Commits(s)

KaydenLe commented 10 months ago

Individual Review Kayden Le grading Hanlun Li

Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom. Individuals Video, Issue(s), Commits(s)

Video in CPT caption style , includes Web demo of key contribution to project, 1 minute Issue(s) that show plans/progress to team objectives Highlights of key commit(s) in Issues, summarizes code contributions Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks Per check. 0.55 not attempted/no check 0.7 attempted, incoomplete, but some runtime 0.8 mastery and runtime 0.9 above and beyond.

Freeform comment. Provide positivies and growth summary. Justify or comment on final score. Be sure to provide extra details on anything below 0.7 average or above 0.8.

0.9 Code commits were consistant and meaningful to the project.

0.85 has consistant commits for the last 3 weeks. 0.85 Issues details key parts of his feature and additions he has added to the feature. 0.9 Issues showcase plans and details of the feature 0.9 Video is in captions giving a full demo and definitions of each part of his feature.

Overall: 0.88/0.9 (97.8)

Idea is cool Make user face better Add instructions I like how the interface goes with the theme but it could be cleaner.

DavidL0914 commented 10 months ago

Individual Review David grading Matthew

Individuals Video, Issue(s), Commits(s)

Overall Comments I like the idea behind your feature. I enjoy being able to see the sheep change colors based on different binary values I input, it helps me to visualize how each change to the binary value ends up changing the resulting RGB color. I like the idea of having random trips scroll through below the sheep. I also think it's cool that you added a "Generate Random Color" button.

I gave you a 0.85/0.9 because I like the idea behind your feature and the representation of RGB colors changing with each binary value I input. However, I think the CSS could be better and the page could be formatted neater and easier to navigate. I also think the "tips" bar is scrolling a bit too fast, so I can't finish reading a tip before a new one switches in. I also think you should add an instructions page to explain how RGB color codes work with binary values as well as how to use your feature effectively. I think if you have extra time you can also add some sort of fun feature, like for example you could make the sheep a certain color and then have the user try to input the three binary values for RGB colors to try to match the color of the sheep as closely as possible. Overall though, the idea behind your feature and the way you implement is still pretty good, it's just going above and beyond that you could work on!

KaydenLe commented 10 months ago

Individual Review Kayden Le grading Hanlun Li

Individuals Video, Issue(s), Commits(s)

ak146 commented 10 months ago

Individual Review Andrew K grading Lakshanya

Individuals Video, Issue(s), Commits(s)

(0.85)

The idea works well. The video displayed the full ideation process and explained the final product well. However, when all the values are put on 255, the text disappears. You should make the text the inverse of the color instead of keeping it a constant value so that it always displays and is more dynamic.

7mwang commented 10 months ago

Individual Review Matthew Wang grading Aditya Desai

Plans could use a little work, more specific Very good participation over the past couple weeks, very consistent. A lot of commits + key commits specified 0.9+0.9+0.9+0.8+0.7 = 4.2/5 = 0.84/0.9

7mwang commented 10 months ago

Team Review Matthew Wang grading Trevor Huang

Team has a good collage of features that display knowledge of binary features and gives a good way to have user interaction. User interaction could be improved, multiple features use image uploading, which isn't the most convenient

Site has a complete selection of features that include what was taught in binary lesson

Again, user interaction wasn't the most convenient, but still good

Plans could still be more clear, flow charts are quite basic .9+.9+.9+.7+.7=0.82/0.9