Drop option in scale_pattern_manual

trevorld / ggpattern

ggplot geoms with pattern fills

https://trevorldavis.com/R/ggpattern/dev/

Other

356 stars 18 forks source link

Drop option in scale_pattern_manual #102

Closed jessvanos closed 9 months ago

jessvanos commented 10 months ago

The "scale_pattern_manual" option does not currently support the "drop=FALSE" when creating a manual legend. This feature is included in "scale_fill_mannual" and would be useful to ensure the legends match.

trevorld commented 10 months ago

Please provide a minimal, self-contained, and reproducible example.
ggplot2::scale_fill_manual() passes ... to ggplot2::discrete_scale() including drop.
Briefly looking at the code I think ggpattern::scale_pattern_manual() also passes ... to ggplot2::discrete_scale()...

trevorld commented 9 months ago

Closing for now since there is no reprex.
Looking at the code the manual scales pass ... (including drop) to ggplot2::discrete_scale(). I don't think I can/should be doing anything differently?