fix: Use 'transform' argument

trevorld / ggpattern

ggplot geoms with pattern fills

https://trevorldavis.com/R/ggpattern/dev/

Other

361 stars 18 forks source link

Closed trevorld closed 5 months ago

trevorld commented 5 months ago

closes #113

trevorld commented 5 months ago

I guess naively swapping all trans with transform would technically be a breaking API change
We should either keep the trans for now and deprecate it or perhaps put a ... in our scale functions and pass it onto the underlying ggplot2 scales
- This may lead to breaking changes if the ... is put where users are setting arguments positionally although the trans argument is near the back...

trevorld commented 5 months ago

Force pushed an update that instead deprecates trans so there shouldn't be any breaking changes
Several continuous scales now gain a ... that can be passed to the underlying ggplot2::continuous_scale()
We know import {lifecycle} but since we import {ggplot2} which imports {lifecycle} this isn't a new net dependency