trevorld / ggpattern

ggplot geoms with pattern fills
https://trevorldavis.com/R/ggpattern/dev/
Other
361 stars 18 forks source link

building package vignettes requires internet connection #30

Closed ghost closed 2 years ago

ghost commented 3 years ago

due to firewall issues, we cannot build the package inside our company, since it fails connecting to placekitten.com and placebear.com. it affects only the vignettes

could you remove this references to third party websites (potentially blocked by firewalls) so that it is buildable "offline"?

ghost commented 3 years ago

   --- re-building 'developing-patterns-1.Rmd' using rmarkdown
   --- finished re-building 'developing-patterns-1.Rmd'

   --- re-building 'developing-patterns-2.Rmd' using rmarkdown
   --- finished re-building 'developing-patterns-2.Rmd'

   --- re-building 'developing-patterns-3.Rmd' using rmarkdown
   --- finished re-building 'developing-patterns-3.Rmd'

   --- re-building 'experimental-pattern-ambient.Rmd' using rmarkdown
   --- finished re-building 'experimental-pattern-ambient.Rmd'

   --- re-building 'experimental-pattern-hex.Rmd' using rmarkdown
   --- finished re-building 'experimental-pattern-hex.Rmd'

   --- re-building 'experimental-pattern-points.Rmd' using rmarkdown
   --- finished re-building 'experimental-pattern-points.Rmd'

   --- re-building 'geom-gallery-array.Rmd' using rmarkdown
   Quitting from lines 40-61 (geom-gallery-array.Rmd) 
   Error: processing vignette 'geom-gallery-array.Rmd' failed with diagnostics:
   Failed to connect to placekitten.com port 443: Timed out
   --- failed re-building 'geom-gallery-array.Rmd'

   --- re-building 'geom-gallery-geometry.Rmd' using rmarkdown
   Warnung: outline.type = "legacy" is only for backward-compatibility and might be removed eventually
   --- finished re-building 'geom-gallery-geometry.Rmd'

   --- re-building 'geometry-based-pattern-parameters.Rmd' using rmarkdown
   --- finished re-building 'geometry-based-pattern-parameters.Rmd'

   --- re-building 'gganimate.Rmd' using rmarkdown
   --- finished re-building 'gganimate.Rmd'

   --- re-building 'pattern-circle.Rmd' using rmarkdown
   --- finished re-building 'pattern-circle.Rmd'

   --- re-building 'pattern-crosshatch.Rmd' using rmarkdown
   --- finished re-building 'pattern-crosshatch.Rmd'

   --- re-building 'pattern-gradient.Rmd' using rmarkdown
   --- finished re-building 'pattern-gradient.Rmd'

   --- re-building 'pattern-image.Rmd' using rmarkdown
   Unzul�ssiger Parameter - 188x241
   Quitting from lines 185-205 (pattern-image.Rmd) 
   Error: processing vignette 'pattern-image.Rmd' failed with diagnostics:
   Rscript.exe: UnableToOpenBlob `C:\Users\xxxx\AppData\Local\Temp\yyyyy\xyxyxyxyxy.png': No such file or directory @ error/blob.c/OpenBlob/2701
   --- failed re-building 'pattern-image.Rmd'

   --- re-building 'pattern-magick.Rmd' using rmarkdown
   --- finished re-building 'pattern-magick.Rmd'

   --- re-building 'pattern-placeholder.Rmd' using rmarkdown
   Quitting from lines 100-115 (pattern-placeholder.Rmd) 
   Error: processing vignette 'pattern-placeholder.Rmd' failed with diagnostics:
   Timeout was reached: [placebear.com] Connection timed out after 10000 milliseconds
   --- failed re-building 'pattern-placeholder.Rmd'

   --- re-building 'pattern-plasma.Rmd' using rmarkdown
   --- finished re-building 'pattern-plasma.Rmd'

   --- re-building 'pattern-stripe.Rmd' using rmarkdown
   --- finished re-building 'pattern-stripe.Rmd'

   SUMMARY: processing the following files failed:
     'geom-gallery-array.Rmd' 'pattern-image.Rmd'
     'pattern-placeholder.Rmd'

   Fehler: Vignette re-building failed.
   Ausf�hrung angehalten

Error: System command 'Rcmd.exe' failed, exit status: 1, stdout + stderr:
E> * checking for file 'xxxxxxx/DESCRIPTION' ... OK
E> * preparing 'ggpattern':
E> * checking DESCRIPTION meta-information ... OK
E> * installing the package to build vignettes
E> * creating vignettes ... ERROR
E> --- re-building 'developing-patterns-1.Rmd' using rmarkdown
E> --- finished re-building 'developing-patterns-1.Rmd'
E> 
E> --- re-building 'developing-patterns-2.Rmd' using rmarkdown
E> --- finished re-building 'developing-patterns-2.Rmd'
E> 
E> --- re-building 'developing-patterns-3.Rmd' using rmarkdown
E> --- finished re-building 'developing-patterns-3.Rmd'
E> 
E> --- re-building 'experimental-pattern-ambient.Rmd' using rmarkdown
E> --- finished re-building 'experimental-pattern-ambient.Rmd'
E> 
E> --- re-building 'experimental-pattern-hex.Rmd' using rmarkdown
E> --- finished re-building 'experimental-pattern-hex.Rmd'
E> 
E> --- re-building 'experimental-pattern-points.Rmd' using rmarkdown
E> --- finished re-building 'experimental-pattern-points.Rmd'
E> 
E> --- re-building 'geom-gallery-array.Rmd' using rmarkdown
E> Quitting from lines 40-61 (geom-gallery-array.Rmd) 
E> Error: processing vignette 'geom-gallery-array.Rmd' failed with diagnostics:
E> Failed to connect to placekitten.com port 443: Timed out
E> --- failed re-building 'geom-gallery-array.Rmd'
E> 
E> --- re-building 'geom-gallery-geometry.Rmd' using rmarkdown
E> Warnung: outline.type = "legacy" is only for backward-compatibility and might be removed eventually
E> --- finished re-building 'geom-gallery-geometry.Rmd'
E> 
E> --- re-building 'geometry-based-pattern-parameters.Rmd' using rmarkdown
E> --- finished re-building 'geometry-based-pattern-parameters.Rmd'
E> 
E> --- re-building 'gganimate.Rmd' using rmarkdown
E> --- finished re-building 'gganimate.Rmd'
E> 
E> --- re-building 'pattern-circle.Rmd' using rmarkdown
E> --- finished re-building 'pattern-circle.Rmd'
E> 
E> --- re-building 'pattern-crosshatch.Rmd' using rmarkdown
E> --- finished re-building 'pattern-crosshatch.Rmd'
E> 
E> --- re-building 'pattern-gradient.Rmd' using rmarkdown
E> --- finished re-building 'pattern-gradient.Rmd'
E> 
E> --- re-building 'pattern-image.Rmd' using rmarkdown
E> Unzul�ssiger Parameter - 188x241
E> Quitting from lines 185-205 (pattern-image.Rmd) 
E> Error: processing vignette 'pattern-image.Rmd' failed with diagnostics:
E> Rscript.exe: UnableToOpenBlob `C:\Users\xxxxxx\AppData\Local\Temp\yyyyy\xyxyxyxyxy.png': No such file or directory @ error/blob.c/OpenBlob/2701
E> --- failed re-building 'pattern-image.Rmd'
E> 
E> --- re-building 'pattern-magick.Rmd' using rmarkdown
E> --- finished re-building 'pattern-magick.Rmd'
E> 
E> --- re-building 'pattern-placeholder.Rmd' using rmarkdown
E> Quitting from lines 100-115 (pattern-placeholder.Rmd) 
E> Error: processing vignette 'pattern-placeholder.Rmd' failed with diagnostics:
E> Timeout was reached: [placebear.com] Connection timed out after 10000 milliseconds
E> --- failed re-building 'pattern-placeholder.Rmd'
E> 
E> --- re-building 'pattern-plasma.Rmd' using rmarkdown
E> --- finished re-building 'pattern-plasma.Rmd'
E> 
E> --- re-building 'pattern-stripe.Rmd' using rmarkdown
E> --- finished re-building 'pattern-stripe.Rmd'
E> 
E> SUMMARY: processing the following files failed:
E>   'geom-gallery-array.Rmd' 'pattern-image.Rmd'
E>   'pattern-placeholder.Rmd'
E> 
E> Fehler: Vignette re-building failed.
E> Ausf�hrung angehalten

 Stack trace:

 1. devtools::build()
 2. pkgbuild::build(path = pkg, dest_path = path, binary = binary,  ...
 3. withr::with_temp_libpaths(rcmd_build_tools(options$cmd, c(options$path,  ...
 4. base:::force(code)
 5. pkgbuild:::rcmd_build_tools(options$cmd, c(options$path, options$args),  ...
 6. pkgbuild:::with_build_tools(callr::rcmd_safe(..., env = env,  ...
 7. withr::with_path(rtools_path(), code)
 8. base:::force(code)
 9. callr::rcmd_safe(..., env = env, spinner = FALSE, show = FALSE,  ...
 10. callr:::run_r(options)
 11. base:::with(options, with_envvar(env, do.call(processx::run,  ...
 12. base:::with.default(options, with_envvar(env, do.call(processx::run,  ...
 13. base:::eval(substitute(expr), data, enclos = parent.frame())
 14. base:::eval(substitute(expr), data, enclos = parent.frame())
 15. callr:::with_envvar(env, do.call(processx::run, c(list(bin, args = real_cmd ...
 16. base:::force(code)
 17. base:::do.call(processx::run, c(list(bin, args = real_cmdargs,  ...
 18. (function (command = NULL, args = character(), error_on_status = TRUE,  ...
 19. throw(new_process_error(res, call = sys.call(), echo = echo,  ...

 x System command 'Rcmd.exe' failed, exit status: 1, stdout + stderr:
E> * checking for file 'xxxxx/DESCRIPTION' ... OK
E> * preparing 'ggpattern':
E> * checking DESCRIPTION meta-information ... OK
E> * installing the package to build vignettes
E> * creating vignettes ... ERROR
E> --- re-building 'developing-patterns-1.Rmd' using rmarkdown
E> --- finished re-building 'developing-patterns-1.Rmd'
E> 
E> --- re-building 'developing-patterns-2.Rmd' using rmarkdown
E> --- finished re-building 'developing-patterns-2.Rmd'
E> 
E> --- re-building 'developing-patterns-3.Rmd' using rmarkdown
E> --- finished re-building 'developing-patterns-3.Rmd'
E> 
E> --- re-building 'experimental-pattern-ambient.Rmd' using rmarkdown
E> --- finished re-building 'experimental-pattern-ambient.Rmd'
E> 
E> --- re-building 'experimental-pattern-hex.Rmd' using rmarkdown
E> --- finished re-building 'experimental-pattern-hex.Rmd'
E> 
E> --- re-building 'experimental-pattern-points.Rmd' using rmarkdown
E> --- finished re-building 'experimental-pattern-points.Rmd'
E> 
E> --- re-building 'geom-gallery-array.Rmd' using rmarkdown
E> Quitting from lines 40-61 (geom-gallery-array.Rmd) 
E> Error: processing vignette 'geom-gallery-array.Rmd' failed with diagnostics:
E> Failed to connect to placekitten.com port 443: Timed out
E> --- failed re-building 'geom-gallery-array.Rmd'
E> 
E> --- re-building 'geom-gallery-geometry.Rmd' using rmarkdown
E> Warnung: outline.type = "legacy" is only for backward-compatibility and might be removed eventually
E> --- finished re-building 'geom-gallery-geometry.Rmd'
E> 
E> --- re-building 'geometry-based-pattern-parameters.Rmd' using rmarkdown
E> --- finished re-building 'geometry-based-pattern-parameters.Rmd'
E> 
E> --- re-building 'gganimate.Rmd' using rmarkdown
E> --- finished re-building 'gganimate.Rmd'
E> 
E> --- re-building 'pattern-circle.Rmd' using rmarkdown
E> --- finished re-building 'pattern-circle.Rmd'
E> 
E> --- re-building 'pattern-crosshatch.Rmd' using rmarkdown
E> --- finished re-building 'pattern-crosshatch.Rmd'
E> 
E> --- re-building 'pattern-gradient.Rmd' using rmarkdown
E> --- finished re-building 'pattern-gradient.Rmd'
E> 
E> --- re-building 'pattern-image.Rmd' using rmarkdown
E> Unzul�ssiger Parameter - 188x241
E> Quitting from lines 185-205 (pattern-image.Rmd) 
E> Error: processing vignette 'pattern-image.Rmd' failed with diagnostics:
E> Rscript.exe: UnableToOpenBlob `C:\Users\xxxxxx\AppData\Local\Temp\yyyyyy\xyxyxyxyxy.png': No such file or directory @ error/blob.c/OpenBlob/2701
E> --- failed re-building 'pattern-image.Rmd'
E> 
E> --- re-building 'pattern-magick.Rmd' using rmarkdown
E> --- finished re-building 'pattern-magick.Rmd'
E> 
E> --- re-building 'pattern-placeholder.Rmd' using rmarkdown
E> Quitting from lines 100-115 (pattern-placeholder.Rmd) 
E> Error: processing vignette 'pattern-placeholder.Rmd' failed with diagnostics:
E> Timeout was reached: [placebear.com] Connection timed out after 10000 milliseconds
E> --- failed re-building 'pattern-placeholder.Rmd'
E> 
E> --- re-building 'pattern-plasma.Rmd' using rmarkdown
E> --- finished re-building 'pattern-plasma.Rmd'
E> 
E> --- re-building 'pattern-stripe.Rmd' using rmarkdown
E> --- finished re-building 'pattern-stripe.Rmd'
E> 
E> SUMMARY: processing the following files failed:
E>   'geom-gallery-array.Rmd' 'pattern-image.Rmd'
E>   'pattern-placeholder.Rmd'
E> 
E> Fehler: Vignette re-building failed.
E> Ausf�hrung angehalten ```
ghost commented 3 years ago

you have fixed paths to local files here: https://github.com/coolbutuseless/ggpattern/blob/390e13fead028ba240eae9293a5ef422df02bc8e/R/pattern-array-image.R#L50

the vignette creation from https://github.com/coolbutuseless/ggpattern/blob/390e13fead028ba240eae9293a5ef422df02bc8e/R/pattern-array-placeholder.R#L67 could be one of the reasons

trevorld commented 3 years ago

we cannot build the package inside our company, since it fails connecting to placekitten.com and placebear.com. it affects only the vignettes

Any reason why you couldn't set the vignettes argument to FALSE in devtools::build() i.e. devtools::build(vignettes = FALSE) i.e. pass the --no-build-vignettes flag to the underlying R CMD build call?

trevorld commented 2 years ago

"placeholder" pattern examples in vignette are now wrapped by try(). So running vignette should not raise any errors if internet connection fails or times out.