WIP: Replace grobs with those from {gridpattern}

trevorld / ggpattern

ggplot geoms with pattern fills

https://trevorldavis.com/R/ggpattern/dev/

Other

359 stars 18 forks source link

WIP: Replace grobs with those from {gridpattern} #42

Closed trevorld closed 3 years ago

trevorld commented 3 years ago

Work-in-progress with goal of replacing {ggpattern}'s internal grid grobs with those from the new {gridpattern} package
- Simplify {ggpattern} codebase and development
- Centralize pattern grob development to {gridpattern} which can also offer grid pattern grob support to non-{ggpattern} packages such as {piecepackr}
Goal is that {ggpattern} user's shouldn't need to change any code unless really picky about placement of geometry elements via use of "offsets":
- {gridpattern} geometry pattern offsets/spacing are in "snpc" unit and center of its "grid" is center of viewport so placement of elements won't be exactly the same
- {gridpattern} array patterns resolution also may not be exactly the same which in particular may tweak 'tiling' appearances

trevorld commented 3 years ago

NB. crimesm <- reshape2::melt(crimes, id = 1) is (more-or-less) equivalent to

crimesm <- stats::reshape(crimes, direction = "long", idvar = "state",
        varying = c("Murder", "Assault", "UrbanPop", "Rape"),
        v.name = "value", timevar = "variable",
        times = c("Murder", "Assault", "UrbanPop", "Rape"))

but none of the examples we create crimesm for actually uses it so we can simply delete all lines that use {reshape2}