search

trevorld / oblicubes

3D rendering using obliquely projected cubes/cuboids
https://trevorldavis.com/R/oblicubes/dev
Other
19 stars 0 forks source link

Release to CRAN #13

Closed trevorld closed 2 years ago

trevorld commented 2 years ago

CRAN comments on initial submission:

Thanks,

Please omit the redundant "Provides functions for" at the start of your
description.

If there are references describing the methods in your package, please
add these in the description field of your DESCRIPTION file in the form
authors (year) <doi:...>
authors (year) <arXiv:...>
authors (year, ISBN:...)
or if those are not available: <https:...>
with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
auto-linking.
(If you want to add a title as well please put it in quotes: "Title")

The MIT license file should only contain the two lines:
YEAR:
COPYRIGHT HOLDER:

Please fix and resubmit.

Best,
Benjamin Altmann
trevorld commented 2 years ago

CRAN comments:

Thanks,

Please combine your LICENSE-file to

YEAR: 2022
COPYRIGHT HOLDER: Trevor L Davis & Mike FC ([mikefc@coolbutuseless.com](mailto:mikefc@coolbutuseless.com))

since there should be only two lines in MIT-license files. If you
believe that this is not sufficient for the LICENSE of 'isocubes',
please share your concerns so that we can find a solution.

Please fix and resubmit.

Best,
Benjamin Altmann

I replied

Dear Benjamin,

According to https://www.r-project.org/Licenses/MIT:

   This is a template.  Provide completed entries of the form

    YEAR:
    COPYRIGHT HOLDER:

    (separated by empty lines) as file LICENSE

My LICENSE file is two entries of the form YEAR: COPYRIGHT HOLDER: separated by an empty line and hence matches the written policy.  Note my project is not a "joint work" so a "joint copyright" statement as you suggested is inappropriate.  It would technically be a violation of the MIT license to unilaterally alter Mike FC's copyright notice in such a way.  The multiline "stacked copyright" statement is legally the "right" way to format an MIT copyright statement in such cases and such multiple line MIT LICENSE statements (YEAR: COPYRIGHT HOLDER: entries separated by empty lines) have been accepted by CRAN as acceptable in previous submissions. 

Thanks,

Trevor
trevorld commented 2 years ago

CRAN writes back:

Hi Trevor,

You are correct, totally my bad! Sorry for bothering you. Please resubmit your package as it is so that we can publish it.

Best,
Beni