search

trevorld / r-optparse

command-line optional argument parser
http://trevorldavis.com/R/optparse/dev/
GNU General Public License v2.0
146 stars 11 forks source link

Replace seq(., along=) with seq_along #13

Closed richfitz closed 9 years ago

richfitz commented 9 years ago

Motivated by avoiding errors when options(warnPartialMatchArgs=TRUE). (alternative fix is to swap along for along.with).

trevorld commented 9 years ago

Do you have a minimal reproducible example of the error you were getting? I could add it to the unit tests so I'm sure the problem was being fixed and it doesn't arise in the future. Do you mind offering me an Unlimited non-exclusive license to your contribution? Although I haven't changed the license in 5+ years I might want to update it at some point in the future... Thanks!

richfitz commented 9 years ago

I've added a test.

I grant you an unlimited non-exclusive license to my contribution.

Can I suggest adding that request to a CONTRIBUTIONS.md file - I believe that will appear as pull requests are made and I would have done it the first time.

Thanks for the great package!

trevorld commented 9 years ago

Your patch has been applied and I've created a CONTRIBUTING file (according to this it should be CONTRIBUTING instead of CONTRIBUTIONS https://github.com/blog/1184-contributing-guidelines). Thanks!