trevoro / node-named

DNS Server in node.js
MIT License
356 stars 100 forks source link

new version to npm #12

Open demmer opened 9 years ago

demmer commented 9 years ago

Can you please publish a new version to npm since I'd like to be able to run with the fix from 73719b0070721ac50115f8895ca799dc6acedd74.

Thanks!

joeyhub commented 9 years ago

Same here but I'm not fond of this fix.

Surely it should just need a return statement in the catch.

    if (!dobj.val)
            return null;

This could be changed to throw. Part of the problem here is inconsistency (protocol throws TypeError but query returns null).

Any kind of unhandled error though should just be a fatal one. Hiding application errors is how hacks happen or how bugs just get hidden away.

I would suggest something like an instanceof check. For example, if(e instanceof ExpectedError)emit else throw(e)...

Though I don't really know the best way in JS to really achieve that.

Anyway, even if the fix is imperfect we still need this in npm. It's a critical problem. My daemon is constantly going down because of this. You can knock it out by just sending anything random to the UDP port.

derhuerst commented 8 years ago

bump.

h43z commented 5 years ago

bump :P

Saiv46 commented 5 years ago

Bump

ghost commented 4 years ago

bump