search

trevorr / react-scroll-manager

Scroll position manager for React applications
ISC License
36 stars 13 forks source link

Added typescript def. file. #2

Closed soerenbf closed 5 years ago

soerenbf commented 5 years ago

Using the library in a typescript react project, and would love simple typings to expose the intended use of the components.

trevorr commented 5 years ago

Thanks for suggesting this. I needed to make some style changes from your PR, but I've included TS definitions in the latest release, 1.0.2.

DonGissel commented 5 years ago

Since PR #2 and #3 have been closed and not merged, you should probably acknowledge the contributions of the authors elsewhere..? 🤔

trevorr commented 5 years ago

This PR is acknowledged in the commit: https://github.com/trevorr/react-scroll-manager/commit/de313da724639b7c879308fdc472376f741fecfa

trevorr commented 5 years ago

Also in the README.md:

Thanks to Anders Gissel for suggesting a fix for IE 11 window scrolling and Søren Bruus Frank for submitting TypeScript definitions.