Closed eaglez closed 8 years ago
This is a useful change to make, but the code is not suitable as-is and needs refactoring. I don't like the unconditional return from a while loop (should be an if statement) and the fact that there's a redundant check in GitExporter.
while
if
GitExporter
I'm closing this for now, but it can be reopened with an updated patch.
This is a useful change to make, but the code is not suitable as-is and needs refactoring. I don't like the unconditional return from a
while
loop (should be anif
statement) and the fact that there's a redundant check inGitExporter
.