search

trevorr / vss2git

Migrate Visual SourceSafe repositories to Git
Apache License 2.0
153 stars 116 forks source link

Allow -1 as value in Combine revisions fields. #36

Closed gitmala closed 7 years ago

gitmala commented 7 years ago

This should disable combining of revisions even if seconds value of 2 commits are equal.

trevorr commented 7 years ago

I think a checkbox would be more appropriate than a magic value in the UI, even if the underlying code sees a magic value.

Also, out of curiosity, what is the motivation for not combining revisions?

gitmala commented 7 years ago

Sure a checkbox would be better. But I could not fix the code logic in a way to incorporate that. But I guess you can do that. The reason for me was to preserve history "As is" in vss. And sice vss has no notion of changesets, then no combining is actually the same on a technical level.

gitmala commented 7 years ago

I did not expect you to merge these changes in, just to be inspired. Also it made the option available to others in case you choose not to implement such behavior.