search

trevorr / vss2git

Migrate Visual SourceSafe repositories to Git
Apache License 2.0
153 stars 116 forks source link

Fix VssPhysicalLib to respect EOF offsets. #48

Closed ifcaro closed 6 years ago

ifcaro commented 6 years ago

Solution proposed by @kornman00 in https://github.com/trevorr/vss2git/issues/47 for the problem 'Attempted read of {0} bytes with only {1} bytes remaining in buffer'.

trevorr commented 6 years ago

Seems safe enough. Have you verified that it fixes the issue for you?

ifcaro commented 6 years ago

Yes, it solved the problem in my case.

Nyk72 commented 3 years ago

When you change a comment of a checkin, VSS does not change the original comment record, but appends a new comment record to the physical file, updating the EOF offset. Therefore the proposed fix let Vss2Git fail to analyse any physical file with a such edited comment, because the iterator skips all the records between the one owning the new comment and the corresponding comment record, while building the changeset list.