search

trevorsandy / lpub3d

An LDraw™ editor for LEGO® style digital building instructions.
https://trevorsandy.github.io/lpub3d/
130 stars 19 forks source link

Applying ROTSTEP causes crash if space in model name #119

Closed trevorsandy closed 5 years ago

trevorsandy commented 5 years ago

Subject

Pressing the button "Apply ROTSTEP" again crash. LPub3D uses the model name and ROTSTEP line number components to form a key which is passed between the 3DViewer and the meta parsing engine. If there is a space in the model name, the key fails to properly 'split' which causes the unexpected behaviour.

Environment

Version of LPub3D - 2.3.0 Operating system - All

Expected behaviour

ROTSTEP applied without crash

Actual behaviour

Sometimes the transform is applied but with additional characters which forces the prompt stating the ROTSTEP meta is malformed. Other times, LPub3D just terminates abnormally without warning

Solution

Corrected. The model name portion of the key has been placed in quotes and parsed accordingly.

trevorsandy commented 5 years ago

This behaviour does not share the same cause as the behaviour described in ticket #82