trevorsandy / lpub3d

An LDraw™ editor for LEGO® style digital building instructions.
https://trevorsandy.github.io/lpub3d/
131 stars 19 forks source link

Loading inline unofficial parts, subparts and primitives #667

Closed trevorsandy closed 1 year ago

trevorsandy commented 1 year ago

Subject

Do not load parts, subparts or primitives into LPub3D LDrawfile repository as submodels.

The LDrawfile repository stores the loaded LDraw model file. There can be cases where the user may choose to inline parts, subparts and/or primitives. In such case, inlined unofficial parts and subparts should not be loaded as submodels. Furthermore, only parts, subparts and/or primitives designated as unofficial should be treated as normal.

Environment

Version of LPub3D - 2.4.6 Operating system - All

Expected behaviour

Display official parts, subparts and/or primitives with warning in the load status when they are inlined in the model file.

Actual behaviour

Parts and subparts are loaded as submodels which causes undefined display behaviour. Primitives are

Solution

Set model file load controls and update load status display dialogue to ensure expected behaviour.

Screenshot - 10_01_2023 , 17_08_28

Screenshot - 10_01_2023 , 16_20_07

Cheers,

trevorsandy commented 1 year ago

This change has been implemented.

Cheers,