trevorsandy / lpub3d

An LDraw™ editor for LEGO® style digital building instructions.
https://trevorsandy.github.io/lpub3d/
131 stars 19 forks source link

Justify outside placement #690

Closed trevorsandy closed 1 year ago

trevorsandy commented 1 year ago

Subject

On multi-step page, outside placement is not properly justified

Screenshot - 20_03_2023 , 00_54_23

Environment

Version of LPub3D - 2.4.6 Operating system - All

Expected behaviour

The Part List Instance in the image below should be centered over the Current Step Image

Actual behaviour

The placement is not properly justified

Solution

Fix it.

Cheers,

trevorsandy commented 1 year ago

This behaviour has been corrected.

Screenshot - 20_03_2023 , 00_58_38

Cheers,

trevorsandy commented 1 year ago

This correction is unfortunately causing a PLI placement regression - see #694.

Unexpected placement car_150_DPI_page_1

Expected placement: car_150_DPI_page_1

Cheers,

trevorsandy commented 1 year ago

This regression has been corrected - I hope :-)

PlacementRegressionOK

Cheers,

trevorsandy commented 1 year ago

This regression has been corrected - I hope :-)

Corrected Pli adjustment failing on vertical allocation:

Unexpected placement Vertical_Divider_KO_625

Corrected placement: Vertical_Divider_OK_625

Cheers,