search

trevorsandy / lpub3d

An LDraw™ editor for LEGO® style digital building instructions.
https://trevorsandy.github.io/lpub3d/
131 stars 19 forks source link

ROTSTEP END is broken? #696

Closed jacovandermolen closed 1 year ago

jacovandermolen commented 1 year ago

Subject

ROTSTEP END seems not to be working

Environment

Steps to reproduce

See this file rotstep.ldr.txt

Expected behaviour

After 0 ROTSTEP END the ROTSTEP should end

Actual behaviour

ROTSTEP is applied to the next step after ROTSTEP too and then applied 2 steps after ROTSTEP END

Workaround

None found

CORRECT rotstep_150_DPI_page_1_correct

INCORRECT rotstep_150_DPI_page_1_incorrect

Please note too that the assembly images are different sizes

trevorsandy commented 1 year ago

Thank you for reporting this behaviour.

I'll take a look.

Cheers,

trevorsandy commented 1 year ago

ROTSTEP END seems not to be working

At what version did you notice the change in behaviour ?

Cheers,

jacovandermolen commented 1 year ago

Atleast in 2.4.6.102.3444, but some cont.build versions before that from last 2 weeks or so. I also noticed that BuildMod in the first step on a multistep doesn't work anymore. I believe we had that one tackeled?

trevorsandy commented 1 year ago

Yep - Looks like the ROTSTEP END behaviour changed at #653.

I've checked in a correction so let me know if the behaviour is restored for you using the DevOps build ?

RotateEnd

I also noticed that BuildMod in the first step on a multistep doesn't work anymore.

Perhaps I'm playing 'wack-a-mole' with BuildMods again. Anyway, I'll take a look.

Cheers,

jacovandermolen commented 1 year ago

OK, 2.4.6.106.3448_20230402 did fix the ROTSTEP END problem, but now crashes on the last page that has the BOM

trevorsandy commented 1 year ago

OK, 2.4.6.106.3448_20230402 did fix the ROTSTEP END problem, but now crashes on the last page that has the BOM

Can you copy paste a command snippet that reproduces this behaviour ? For me the BOM is generated as expected.

RotateEnd_01

Cheers,

technicbasics commented 1 year ago

Hi Trevor It looks like for me, that also the "0 ROTSTEP x y z REL" is also broken. In my file that I have made available to you, from step 45 (page 14), no single ROTSTEP command works anymore. But this concerns only the main model. In the submodels the ROTSTEPS are executed correctly. Oh, I almost forgot... Version 2.4.6r106 DevOps

trevorsandy commented 1 year ago

It looks like for me, that also the "0 ROTSTEP x y z REL" is also broken.

Very well - I'll take another look.

There are lots of dependencies so it's good to have many eyes taking a look.

Cheers,

trevorsandy commented 1 year ago

This behaviour has been corrected.

Cheers,

technicbasics commented 1 year ago

Works fine in 2.4.6r131 :-)