trevorsandy / lpub3d

An LDraw™ editor for LEGO® style digital building instructions.
https://trevorsandy.github.io/lpub3d/
130 stars 19 forks source link

Edge line configuration gets resetted #712

Closed Dark-Noir closed 1 year ago

Dark-Noir commented 1 year ago

Subject

Edge line configuration (for the edge lines of the bricks) is no longer possible. The setting can be changed, but it is not applied and is resetted, after re-opening the preferences. Last working version 2.4.4.

Environment

Configuration

Logs

Screenshots

Preconditions

  1. Fresh *.zip extracted

Steps to reproduce

  1. Start LPub3D.exe
  2. Select your LDraw lib
  3. Go to "Configuration -> Preferences -> Renderers"
  4. Set "Edge Lines" to any value greater than 1
  5. Close the menu with "OK"
  6. Re-open the menu

You can optional load a *.ldr file for testing.

Expected behavior

Actual behavior

Workaround

Use a older version, last working one 2.4.4.

Solution suggestion

Fix it and please change the slider to a text field, to enter values directly ^^

Dark-Noir commented 1 year ago

Found the a second menu at "Visual Editor -> Preferences" where i can change the configuration and it also gets saved. Not sure why the same menu is at two locations, but it should be fixed (and also the slider changed to a text field for direct input).

trevorsandy commented 1 year ago

Thank you for reporting this behaviour.

This behaviour has been corrected.

Not sure why the same menu is at two locations

The "Visual Editor -> Preferences" dialogue is also present in the LPub3D Preferences window for convenience.

and also the slider changed to a text field for direct input

LPub3D uses the OpenGL (Open Graphics Library) programming interface (API) to render 3D vector graphics. Line width greater than 1.0 has been deprecated since v3.0, however, while most GPUs support this capability, its implementation must be done in a way to ensure line width values not equal to 1.0 are supported. To this end, it is not a good idea to allow an open line-width input scheme.

Cheers,