Submodels shown in BOM when using INSERT DISPLAY_MODEL

[trevorsandy]

Subject

Submodels are shown as parts in the BOM when using INSERT DISPLAY_MODEL meta command.

Environment

Version of LPub3D - 2.4.7 Operating system - All

Expected behaviour

Submodels should not be present in the BOM.

Actual behaviour

Submodels are present in the BOM

LPub3D - 2.4.7r52:

LPub3D - 2.4.7r53 and 2.4.7r52

Solution

Fix it.

Cheers,

[trevorsandy]

This behaviour was introduced by #704.

With #704, lines are parsed for the INSERT DISPLAY_MODEL command during model load. A 'display model' flag is set when this command is encountered and, incorrectly, was only reset after encountering a type 1-5 line or end of file. As a result, when a STEP containing this command does not have any type 1-5 lines defined (the behaviour before #704), the first submodel encountered after the display model STEP would be flagged as a display model. Consequently, this erroneous submodel setting would trigger a false positive for the 'is part' condition when the submodel is encountered during BOM creation.

This behaviour has been corrected.

Before correction:

After correction:

Cheers,

[technicbasics]

Amazing! Thank you very much Trevor. 👍🏻