search

trevorsandy / lpub3d

An LDraw™ editor for LEGO® style digital building instructions.
https://trevorsandy.github.io/lpub3d/
136 stars 19 forks source link

Random crash when saving results in corrupt LDraw file #744

Closed jacovandermolen closed 1 month ago

jacovandermolen commented 1 year ago

Subject

Random crash when saving results in corrupt LDraw file

Environment

Steps to reproduce

Working on a model and saving the file results in crash. Seemed random at any other given moment or after some editing. However, I am able to constant reproduce in the case, when opening an LDraw file that has LPub formatting and unformat the document resulting in this dmp file

LPub3D.dmp

Expected behaviour

LPub3D should not crash when saving an LDraw file and not corrupt it.

Actual behaviour

LPub3D crashes when saving a file and corrupts it. It seems the complete file is not written, since it abruptly and randomly ends the file at some random line.

Workaround

None found.

trevorsandy commented 2 months ago

Thank you for reporting this behaviour. I'll take a look.

Cheers,

jacovandermolen commented 2 months ago

Hi Trevor, Its been a while, but it seems you are picking up working on LPub3D again? I am looking forward to more development :-)

trevorsandy commented 1 month ago

I don't have the binary that generated this dump so the debug analysis is unremarkable. However, I believe #741 to be the part of the source of this behaviour. Additionally, since this behaviour was reported, I have refactored a lot of code for the command editor. With these updates in place, plus those put in place for #767, I am not able to trigger a AbEnd on the latest DevOps build.

Considering the age of this ticket and the updates state of LPub3D, I'm going to close this ticket. I you experience the behaviour reported in this ticket in the latest DevOps release, do not hesitate to let me know.

Cheers,