trevorsandy / lpub3d

An LDraw™ editor for LEGO® style digital building instructions.
https://trevorsandy.github.io/lpub3d/
136 stars 19 forks source link

Final INSERT MODEL - command placed after BOM - should be before #770

Closed ReneFrijhoff closed 4 weeks ago

ReneFrijhoff commented 4 weeks ago

Subject

The meta command 'Insert model' gives an error no matter where you place it and it's automatically added when using faded steps. It's also inserted at the wrong position, at the end of the main model instead after the last submodel/part. This causes the lines to be added after the BOM if that's already inserted.

Environment

Configuration

[Note: Provide details and content below as needed with appropriate redactions. To produce the Windows registry extract for an installed distribution, go to the command console and enter the command line shown. The extract file will be placed on your desktop.]

Screenshots

MPD file - USS Deadalus.zip

Steps to reproduce

Enable fading (I'm using the native renderer)

Expected behaviour

No error

Actual behaviour

Error, paging through in LPUB3D as well as exporting as a PDF, depending on whether you click Ignore or Abort it does (Ignore) or it doesn't (Abort) generate that picture. Also this error message only happens when loading the file for the first time and choosing Ignore, or every time as long as you choose Abort or closing and loading the file again.

Workaround

Don't use fading steps or only choose Ignore, but in that case you have to do it every time you load the file.

Solution suggestion

Sorry, no solution. In this case I don't have the knowledge.

trevorsandy commented 4 weeks ago

Thank you for reporting this behaviour. I will take a look.

In parallel, can you confirm that the behaviour you are reporting is present in the latest DevOps build ?

LPub3D has evolved quite a bit since r75. I am just about to approve the latest production release which is at r236.

You can evaluate this and other updates in the soon-to-be-released v2.4.8 DevOps build.

Cheers,

ReneFrijhoff commented 4 weeks ago

Even in the latest DevOps build the problem exists.

Cheers,

Op wo 16 okt 2024 om 18:45 schreef Trevor SANDY @.***>:

Thank you for reporting this behaviour. I will take a look.

In parallel, can you confirm that the behaviour you are reporting is present in the latest DevOps build ?

LPub3D has evolved quite a bit since r75. I am just about to approve the latest production release which is at r236.

You can evaluate this and other updates in the soon-to-be-released v2.4.8 DevOps https://github.com/trevorsandy/lpub3d-ci/releases/tag/continuous build.

Cheers,

— Reply to this email directly, view it on GitHub https://github.com/trevorsandy/lpub3d/issues/770#issuecomment-2417378151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBJ6GMYS2CRRWE6PLHJQJDZ32J4BAVCNFSM6AAAAABQBJ2R3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGM3TQMJVGE . You are receiving this because you authored the thread.Message ID: @.***>

trevorsandy commented 4 weeks ago

I have confirmed the improper placement after the BOM. This behaviour will be corrected.

Workaround

A reasonable workaround, particularly useful when exporting, is to add the following global meta command to your document.

0 !LPUB FINAL_MODEL_ENABLED GLOBAL FALSE

Cheers,

ReneFrijhoff commented 4 weeks ago

I added the line to the document, unfortunately the error still appears.

Cheers,

Op wo 16 okt 2024 om 21:04 schreef Trevor SANDY @.***>:

I have confirmed the improper placement after the BOM. This behaviour will be corrected. Workaround

A reasonable workaround, particularly useful when exporting, is to add the following global meta command to your document.

0 !LPUB FINAL_MODEL_ENABLED GLOBAL FALSE

Cheers,

— Reply to this email directly, view it on GitHub https://github.com/trevorsandy/lpub3d/issues/770#issuecomment-2417694251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBJ6GPVRVOLNDBGKBBDBYTZ322EVAVCNFSM6AAAAABQBJ2R3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGY4TIMRVGE . You are receiving this because you authored the thread.Message ID: @.***>

trevorsandy commented 4 weeks ago

Ok - To be more precise:

Goal: Disable the automatic adding of the 6 final model lines when fade/highlight steps is enabled.

  1. remove the 6 unwanted 'final model' lines manually if they exist in the disc instance of the model file
  2. add the above prescribed meta command to prevent automatically adding the final model lines on the next file load

The error message you are experiencing is basically saying that your INSERT MODEL.. command is sharing the same STEP with type 1-5 'part' lines. Obviously, this is not good because you want your model to display on its own page so simply place a 0 STEP command between the 1-5 part lines and the INSERT MODEL command.

There is no INSERT MODEL meta command in the sample model file you sent me so I cannot see exactly what is going on with your file load. However, there are several strange lines with double 0s - 0 0 !LPUB INSERT BOM which I do not understand.

Cheers,

ReneFrijhoff commented 4 weeks ago

Ok, thanks for the explanation, I will try that. As fior the model file, it seems it was the wrong version. So here it is again.

Cheers,

Op wo 16 okt 2024 om 22:11 schreef Trevor SANDY @.***>:

Ok - To be more precise:

Goal: Disable the automatic adding of the 6 final model lines when fade/highlight steps is enabled.

  1. remove the 6 unwanted 'final model' lines manually if they exist in the disc instance of the model file 2 add the above prescribed meta command to prevent automatically adding the final model lines on the next file load

The error message you are experiencing is basically saying that your INSERT MODEL.. command is sharing the same STEP with type 1-5 'part' lines. Obviously, this is not good because you want your model to display on its own page so simply place a 0 STEP command between the 1-5 part lines and the INSERT MODEL command.

There is no INSERT MODEL meta commands in the sample model file you sent me so I cannot see exactly what is going on with your file load. However, there are several strange lines with double 0s - 0 0 !LPUB INSERT BOM which I do not understand.

Cheers,

— Reply to this email directly, view it on GitHub https://github.com/trevorsandy/lpub3d/issues/770#issuecomment-2417851017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBJ6GOCVZW35IENMITN5ITZ33B5ZAVCNFSM6AAAAABQBJ2R3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXHA2TCMBRG4 . You are receiving this because you authored the thread.Message ID: @.***>

ReneFrijhoff commented 4 weeks ago

I also found that now the lines

0 STEP

0 !LPUB INSERT COVER_PAGE BACK

are added every time I load the file.

[image: image.png] [image: image.png] [image: image.png] Cheers,

Op wo 16 okt 2024 om 22:11 schreef Trevor SANDY @.***>:

Ok - To be more precise:

Goal: Disable the automatic adding of the 6 final model lines when fade/highlight steps is enabled.

  1. remove the 6 unwanted 'final model' lines manually if they exist in the disc instance of the model file 2 add the above prescribed meta command to prevent automatically adding the final model lines on the next file load

The error message you are experiencing is basically saying that your INSERT MODEL.. command is sharing the same STEP with type 1-5 'part' lines. Obviously, this is not good because you want your model to display on its own page so simply place a 0 STEP command between the 1-5 part lines and the INSERT MODEL command.

There is no INSERT MODEL meta commands in the sample model file you sent me so I cannot see exactly what is going on with your file load. However, there are several strange lines with double 0s - 0 0 !LPUB INSERT BOM which I do not understand.

Cheers,

— Reply to this email directly, view it on GitHub https://github.com/trevorsandy/lpub3d/issues/770#issuecomment-2417851017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBJ6GOCVZW35IENMITN5ITZ33B5ZAVCNFSM6AAAAABQBJ2R3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXHA2TCMBRG4 . You are receiving this because you authored the thread.Message ID: @.***>

trevorsandy commented 4 weeks ago

This behaviour has been corrected.

In the following example, you can see the final model is placed before several BOM pages and a back cover page. FadeStepsInsertModel_3

This example presents the substitute part scenario FadeStepsInsertModel_5

Of course, this capability can be tailored per the comments preceding the 0 !LPUB INSERT MODEL command which is stating to disable the automatic inclusion of this meta command when the model is loaded, replace MODEL with DISPLAY_MODEL - resulting with the meta command

0 !LPUB INSERT DISPLAY_MODEL.

As stated above, you can also totally suppress this behaviour with meta command:

0 !LPUB FINAL_MODEL_ENABLED GLOBAL FALSE

Or you can uncheck 'Enable Final Model Step' in either the Fade Steps or Highlight Step global setup

Global setup menu FadeStepsInsertModel_1 FadeStepsInsertModel_2

I also found that now the lines... 0 !LPUB INSERT COVER_PAGE BACK are added every time I load the file.

You can see in the third configuration screenshot you posted that the 'Generate Cover Pages' checkbox is checked. Uncheck this preference to remove the automatic generation of your front and back cover page.

FadeStepsInsertModel_4

Cheers,