search

trevorturk / flash_cookie_session

Rails 3 cookie sessions can cooperate with Flash
79 stars 16 forks source link

nil-error with rack 1.4.1 #12

Closed fwoeck closed 12 years ago

fwoeck commented 12 years ago

Hi, with rack 1.4.1 I'm getting the following error:

NoMethodError (cannot parse Cookie header: undefined method `size' for nil:NilClass):
  rack (1.4.1) lib/rack/utils.rb:445:in `[]='
  rack (1.4.1) lib/rack/utils.rb:76:in `block in parse_query'
  rack (1.4.1) lib/rack/utils.rb:66:in `each'
  rack (1.4.1) lib/rack/utils.rb:66:in `parse_query'
  rack (1.4.1) lib/rack/request.rb:263:in `cookies'
  actionpack (3.2.1) lib/action_dispatch/middleware/cookies.rb:110:in `block in build'
  actionpack (3.2.1) lib/action_dispatch/middleware/cookies.rb:109:in `tap'
  actionpack (3.2.1) lib/action_dispatch/middleware/cookies.rb:109:in `build'
  actionpack (3.2.1) lib/action_dispatch/middleware/cookies.rb:7:in `cookie_jar'
  actionpack (3.2.1) lib/action_dispatch/middleware/session/cookie_store.rb:53:in `block in unpacked_cookie_data'
  actionpack (3.2.1) lib/action_dispatch/middleware/session/abstract_store.rb:55:in `stale_session_check!'
  actionpack (3.2.1) lib/action_dispatch/middleware/session/cookie_store.rb:51:in `unpacked_cookie_data'
  rack (1.4.1) lib/rack/session/cookie.rb:98:in `extract_session_id'
  actionpack (3.2.1) lib/action_dispatch/middleware/session/abstract_store.rb:51:in `block in extract_session_id'
  actionpack (3.2.1) lib/action_dispatch/middleware/session/abstract_store.rb:55:in `stale_session_check!'
  actionpack (3.2.1) lib/action_dispatch/middleware/session/abstract_store.rb:51:in `extract_session_id'
  rack (1.4.1) lib/rack/session/abstract/id.rb:43:in `load_session_id!'
  rack (1.4.1) lib/rack/session/abstract/id.rb:32:in `[]'
  rack (1.4.1) lib/rack/session/abstract/id.rb:262:in `current_session_id'
  rack (1.4.1) lib/rack/session/abstract/id.rb:268:in `session_exists?'
  rack (1.4.1) lib/rack/session/abstract/id.rb:107:in `exists?'
  rack (1.4.1) lib/rack/session/abstract/id.rb:122:in `load_for_read!'
  rack (1.4.1) lib/rack/session/abstract/id.rb:64:in `has_key?'
  actionpack (3.2.1) lib/action_dispatch/middleware/flash.rb:258:in `ensure in call'
  actionpack (3.2.1) lib/action_dispatch/middleware/flash.rb:259:in `call'
  rack (1.4.1) lib/rack/session/abstract/id.rb:205:in `context'
  rack (1.4.1) lib/rack/session/abstract/id.rb:200:in `call'
  flash_cookie_session (1.1.1) lib/flash_cookie_session/middleware.rb:18:in `call'

when I try to upload files. rack 1.4.0 ist just fine. Thank you for your help, best regards, Frank

trevorturk commented 12 years ago

@fwoeck sorry but I'm not doing much support for this gem lately. If you'd like to work up a pull request that would be great, though!

fwoeck commented 12 years ago

Hi @trevorturk, that's fine, I'll give it a try!

fwoeck commented 12 years ago

Actually, this has already been fixed in master - the gem hasn't been updated though.

trevorturk commented 12 years ago

Ah ha! I'll update the gem.