trevorwang / retrofit.dart

retrofit.dart is an dio client generator using source_gen and inspired by Chopper and Retrofit.

https://mings.in/retrofit.dart/

MIT License

1.09k stars 251 forks source link

Considering replacing json_seralizable by dart_json_mapper #183

Closed trevorwang closed 4 years ago

trevorwang commented 4 years ago

I am considering using dart_json_mapper as the default data serialization engine.

Any ideas here?

JasonHezz commented 4 years ago

I'd love to do some PR, but this is a break change.

trevorwang commented 4 years ago

Yes. I am planning to do refactoring on version 2

JasonHezz commented 4 years ago

Any roadmap? As far as I can see, there are something we can improve. Move json serialization logic out of generator. Like retrofit-converters

trevorwang commented 4 years ago

Not yet.

I will create a new issue discussing the roadmap.

184

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

trevorwang commented 4 years ago

dart_json_mapper has limitation on dart code obfuscate

https://pub.dev/packages/dart_json_mapper#known-limitations

keeping using json_serializable until there's a better solution.

xVemu commented 1 year ago

Any news on this after 3 years?