[v3] Implement RFC 7366 - Encrypt-then-MAC

tomato42 commented 9 years ago

Implements the encrypt then MAC mechanism for CBC based cipher suites in TLS. Add some simple tests for HandshakeSettings.

Missing:

client side check for EtM advertised in server hello together with stream or AEAD cipher (it's incorrect use and it will fail to interoperate but won't report correct errors - I'd rather test it using mechanism introduced in #47)
ability to force use of EtM (abort connection when server didn't select EtM but did select CBC cipher suite - that will need to wait for AEAD to be actually useful)

Changes since v2:

reworked "move MAC-then-encrypt", "etm decryption" and "etm decryption" to fix most pylint complaints
rebased on master

Changes since v1:

reworked "etm decryption" and "etm encryption" patches to better show what is happening, unfortunately the "move MAC-then-encrypt to separate methods" is still rather hard to read, but it's not really possible to make it any better
rebased on master with fixed tests

Obsoletes #52

tomato42 commented 9 years ago

when can I expect review?

trevp commented 9 years ago

Next week.

trevp commented 9 years ago

Hi Hubert, added some line comments. Also:

have you done interop testing w/another library?
RFC 7366 mentions that once EtM has been negotiated, it should be used for resumed sessions, could you add that?

tomato42 commented 9 years ago

have you done interop testing w/another library?

yes, I tested against the eid server mentioned in drafts

RFC 7366 mentions that once EtM has been negotiated, it should be used for resumed sessions, could you add that?

I'll look into that

tomato42 commented 9 years ago

fully obsoleted, closing

trevp / tlslite