search

treydock / eseries_exporter

Apache License 2.0
5 stars 2 forks source link

The "storage-systems/analysed-controller-statistics" API call is deprecated #25

Closed bazmonk closed 2 weeks ago

bazmonk commented 2 weeks ago

In newer e5760s, it appears that the analysed-controller-statistics API call has been deprecated and is no longer available. This looks to be how the controller-statistics is grabbing data.

Is this project maintained at all? There are slightly different versions of this call that could be used instead. Wanted to check if there's any interest in fixing this before I go attempting to fork this.

Thanks!

bazmonk commented 2 weeks ago

Never mind: I went at it on my own.

treydock commented 4 days ago

@bazmonk If you'd like to open a PR I'd be glad to take a look and get it merged and released. My site no longer has ESeries hardware so I no longer have the ability to test this exporter.

bazmonk commented 4 days ago

Thanks... I'll ask my work about that (since it was for work I have to go through them to release code).

I must admit I know basically no golang, and just learned enough to make it work. I had to adjust the exact API call being made, and I had to adjust how the URL was parsed in the json unmarshalling. None of the calls in your code used a ?foo=bar query string and the code as-is wasn't parsing it out correctly.

I also don't have a dev machine that can reach our eseries controllers or web proxy, so I couldn't see the test portions of the make process work, but it produces the binary so that works for us.

-Baz

On Wed, Nov 27, 2024 at 5:14 AM treydock @.***> wrote:

@bazmonk https://github.com/bazmonk If you'd like to open a PR I'd be glad to take a look and get it merged and released. My site no longer has ESeries hardware so I no longer have the ability to test this exporter.

— Reply to this email directly, view it on GitHub https://github.com/treydock/eseries_exporter/issues/25#issuecomment-2503849363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX5QOH6HGXIVABRDF3AYJID2CXARVAVCNFSM6AAAAABRXTKNEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBTHA2DSMZWGM . You are receiving this because you were mentioned.Message ID: @.***>