Closed Dmitry099 closed 1 year ago
Hello @treydock, I don't have an opportunity to add you as a reviewer in PR, but I just want to highlight what I've opened it to you as you the author and main contributor to this repo. Could you please review this PR then you'll have time?
I left some inline comments.
Hello @treydock, kindly reminder - could you please review PR after appropriate changes?
@Dmitry099 I left one inline suggestion so that folks using the metrics can very clearly see the unit associated with the metric. Other changes look good.
@Dmitry099 I left one inline suggestion so that folks using the metrics can very clearly see the unit associated with the metric. Other changes look good.
Hello, @treydock! Could you please review PR after last changes? Thank you in advance!
This was released as v2.3.0 - https://github.com/treydock/gpfs_exporter/releases/tag/v2.3.0
Good day! This library is really useful for generating GPFS metrics. However, we want to generate additional metrics from the output of
mmlsqos
command, which isn't included here. So, I've created this PR with my implementation to reach this goal. P.S. I've already tested it in my dev environment and it works as expected.