search

treygriffith / swap-compatibility

http://swapready.net
10 stars 6 forks source link

Include BarterDEX as Atomic Swap Implementation #1

Closed polycryptoblog closed 6 years ago

polycryptoblog commented 6 years ago

BTC, BTCH, Dash,DOGE,Groestlcoin, Litecoin, Syscoin,Viacoin,Vertcoin and Zcash all have fully working on chain atomic swaps available in Komodo Platform's BarterDEX application.

All of them are compatible with each other as well.

The chart should be updated to reflect this.

treygriffith commented 6 years ago

@polycryptoblog can you link me to the GitHub repo with the working atomic swap implementation? Would love to get this updated.

polycryptoblog commented 6 years ago

Sure https://github.com/KomodoPlatform/BarterDEX, try it out. I am not the most technical of people and I was able to get swaps going. This is a game changer

treygriffith commented 6 years ago

@polycryptoblog it looks like the actual swap code is here: https://github.com/KomodoPlatform/KomodoPlatform/blob/master/basilisk/basilisk_swap.c

This is a different style of swap than I'm familiar with, so integrating it into the chart will take some time.

For example, it only requires one of the two coins in the swap to support CLTV.

treygriffith commented 6 years ago

@polycryptoblog I opened issue https://github.com/jl777/SuperNET/issues/553 with the Komodo devs to get an answer to a question before I include it as an atomic swap.

polycryptoblog commented 6 years ago

The lead developer, jl777 can better help explaining it than me here is his github, https://github.com/jl777

treygriffith commented 6 years ago

Based on my understanding of the protocol in use by BarterDEX (and confirmed by the lead dev), it is not a trustless atomic swap. Closing this issue as I don't consider it appropriate to include a non-trustless atomic swap in the chart.