treyhunner / names

Random name generator
MIT License
462 stars 107 forks source link

Faster #11

Open shiver opened 10 years ago

shiver commented 10 years ago

Made some small changes to allow the name files to be cached and also making use of multiprocessing to aid in generating a large number of names a little quicker.

Not a wonderful change, but your project helped me out in testing so I thought I would at least share my changes. Feel free to use it if you want.

Thanks

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-27.08%) when pulling 8e5685eb78d4e707b84812f616a8c5f6ce8824e4 on shiver:faster into e6aa9db6475fb19595963e506b6ef3e4c2bc6a78 on treyhunner:master.

treyhunner commented 10 years ago

Thanks for the pull request @shiver. I don't have a particular need for these changes right now and I prefer to have tests for all new additions.

For now, I will leave this pull request open for others to see, use, and comment on. I might look into this and merge it in the future. :octocat:

shiver commented 10 years ago

No worries.

The patch is a bit "hacky", since I just made the quick adjustments for my needs. If I get the chance I may tidy it up a bit and add some tests.

Thanks again for project. :)