Ensure file handles are closed using with statement

treyhunner / names

Random name generator

MIT License

462 stars 107 forks source link

Ensure file handles are closed using with statement #5

Closed svisser closed 10 years ago

svisser commented 10 years ago

This change ensures the file handles in setup.py are properly closed using the with statement.

treyhunner commented 10 years ago

Hey @svisser, thanks for the pull request.

It looks like the tests are failing currently due to a typo.

coveralls commented 10 years ago

Coverage remained the same when pulling 6185ba5a24cb17574aceb243f0bc6d755dc240c1 on svisser:patch-1 into 3b475ddf541a21d9751c22675387ec7fbb7dbc77 on treyhunner:master.

svisser commented 10 years ago

@treyhunner thanks for mentioning, it's fixed now.

treyhunner commented 10 years ago

Great. Thanks again for the pull request.