fix issue 51 - Githubissues

goliath-walker commented 2 years ago

fixes #51

treymo commented 2 years ago

Do you mind explaining what is wrong here? Does it error out on the link.attr access if there are no links? Did you find this running the plugin in dev mode?

goliath-walker commented 2 years ago

Sure - I am no expert with d3.js, but here is what (I guess) happens:

Before this PR, in the ticked function, edges will be re-positioned before nodes, whereas the selected node is manually adjusted to center
This apparently is a problem, if in the last tick the edge is positioned inline with selected/current node, but then this node is centered manually back from a different position
(Larger min distance in https://github.com/treymo/joplin-link-graph/blob/main/src/ui/index.js#L49 might play into this issue as well, but not tested)
The resulting effect can be seen in the issue: node is spiked somewhere in the middle of the edge
With more than two nodes, selected node seems to be stable in the center over course of ticks, so no problem here
PR just switches the order: First center selected node, then apply the edge on changed coords.

treymo commented 2 years ago

Awesome, thanks for the info and the fix! I'm obviously no JS/d3 expert haha

treymo / joplin-link-graph

fix issue 51 #54