search

treymo / joplin-link-graph

UI for viewing connections between different Joplin notes
MIT License
252 stars 10 forks source link

Feat: Add inline graph setting for max distance (maxDegree) #62

Closed goliath-walker closed 2 years ago

goliath-walker commented 2 years ago

screenshot

Inline settings allow quick adjustments to viewed graph and its distance. maxDegree setting is removed from the settings (made private), but still is persisted each time the range slider is changed.

Second commit is a quick-fix for degrading font-size, when distance gets bigger. Previous percent-based settings did not make so much sense, as no proper parent element to rely on.

treymo commented 2 years ago

Both of these PRs look great. We will be able to do a lot with this on-graph setting panel! Just resolve the merge conflicts here and I'll re-test and approve

goliath-walker commented 2 years ago

Yeah, current solution should be perfectly fine even for two more fields or so, I guess. With much more, we should discuss a possible generalization API for multiple inline inputs, as passing callback + initial value for each field might become ugly. Thanks for approving!