Open wakiyamap opened 2 months ago
We have added Testnet4 config by this commit d8c68f2b6b7d9a08d99a6a68f8215b84d3f1f8dd. However we did not add integration tests yet. Would you mind if we take them from your fork and integrate them?
It's good, but I don't know if it will work.
Also, testnet4 does not work with the current github.com/martinboehm/btcutil/chaincfg
.
Changes to bitcoinparser.go
are required.
https://github.com/wakiyamap/blockbook/commit/a3690b3eb144aeb30cf9e770687942158c351de8#diff-e8f35690e3557a170294ecf41264a45672b4667b0bec0cd08cc06954a34fb072R7
Hello, thanks for your work here! As mentioned by Martin above, we will cherry-pick your commit and synchronize it with current master
- while leaving your authorship. I hope it is fine for you :)
Hello, thanks for your work here! As mentioned by Martin above, we will cherry-pick your commit and synchronize it with current
master
- while leaving your authorship. I hope it is fine for you :)
ok. no problem.
......So what is the correct test command for testnet?
I am currently creating a pull request for testnet4. https://github.com/wakiyamap/blockbook/commits/testnet4-bitcoin/
The testing method seems to be different from before, so I would like to confirm it. If I were to test it, would the following command be okay?
make test
and
make test-integration ARGS="-v -run=TestIntegration/bitcoin_testnet4=main"